docs(sdk): define ESM module contract - #47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public change
Document the module-format contract for the first public
@brida/sdkrelease.@brida/sdk@0.1.0is ESM;require('@brida/sdk')is not part of the 0.1 contract;import();This closes an ambiguity found during pre-publication clean-room testing: current later Node 22 releases may load ESM via
require(), but exact Node 22.0.0 correctly rejects it withERR_REQUIRE_ESM.Validation
Exact head:
192ab541271abaf1af62d0bc4e95866b3807dd36.pnpm check: PASS;Compatibility / risk
Docs/architecture only. Runtime/package exports are unchanged.
Release intent