Skip to content

Accept legacy double-quoted map name in FML grammar - #85

Merged
brianpos merged 5 commits into
developfrom
copilot/add-cross-version-canonical-processing
Jul 31, 2026
Merged

brianpos merged 5 commits into
developfrom
copilot/add-cross-version-canonical-processing

Conversation

Copilot AI commented Jun 11, 2026

Copy link
Copy Markdown

Legacy FML maps that quote the map name (e.g. map "…/syntax" = "Syntax") failed to parse for the diagram display, since the published FHIR grammar only allows a bare/delimited identifier there. The HAPI engine tolerates the quoted form, so the lab parser should too.

Changes

  • Grammar (fml-parser/FmlMapping.g4): mapDeclaration now accepts DOUBLE_QUOTED_STRING as an alternative to identifier, with an inline comment flagging it as the legacy, HAPI-tolerant format. Confined to mapDeclarationidentifier is untouched.
  • Parser: regenerated via ANTLR 4.13.2 (FmlMappingParser.ts, FmlMapping.interp).
  • Model builder (helpers/fml_visitor.ts): visitMapDeclaration reads the name from either node and strips the surrounding quotes via the existing removeQuotes helper.
  • Test (test/fml-cross-version.test.ts): regression case asserting the quoted name resolves to Syntax.
mapDeclaration
  : 'map' url '=' (identifier | DOUBLE_QUOTED_STRING) // double quoting is a legacy format, and tollerant of content handled by the HAPI engine
  ;

Copilot AI changed the title Detect cross-version FHIR canonicals in FML uses declarations Merge latest develop into cross-version FML branch Jun 11, 2026
Copilot AI requested a review from brianpos June 11, 2026 08:52
@brianpos
brianpos changed the base branch from master to develop June 11, 2026 09:01
@github-actions

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://yellow-plant-0209dde10-85.centralus.3.azurestaticapps.net

@github-actions

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-water-06b155100-85.eastasia.4.azurestaticapps.net

Copilot AI changed the title Merge latest develop into cross-version FML branch Make FML diagrams cross-version aware; always show Instance tab Jun 11, 2026
@github-actions

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://yellow-plant-0209dde10-85.centralus.3.azurestaticapps.net

@github-actions

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-water-06b155100-85.eastasia.4.azurestaticapps.net

Copilot AI changed the title Make FML diagrams cross-version aware; always show Instance tab Accept legacy double-quoted map name in FML grammar Jun 12, 2026
@github-actions

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://yellow-plant-0209dde10-85.centralus.3.azurestaticapps.net

@github-actions

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-water-06b155100-85.eastasia.4.azurestaticapps.net

@brianpos
brianpos marked this pull request as ready for review July 31, 2026 02:24
@brianpos
brianpos merged commit 60cc7a4 into develop Jul 31, 2026
4 checks passed
@brianpos
brianpos deleted the copilot/add-cross-version-canonical-processing branch July 31, 2026 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants