Skip to content

Add Open Health Stack's Kotlin FhirPath engine - #80

Merged
brianpos merged 6 commits into
brianpos:developfrom
ohs-foundation:ohs-engine
Aug 26, 2026
Merged

brianpos merged 6 commits into
brianpos:developfrom
ohs-foundation:ohs-engine

Conversation

@LZRS

@LZRS LZRS commented Jun 4, 2026

Copy link
Copy Markdown

Adds OHS FhirPath engine, with the server api implementation https://github.com/ohs-foundation/kotlin-fhirpath-server

@jingtang10 jingtang10 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @LZRS. can you take a look at this PR: #57 and see there's anything else that needs to be added?

Comment thread static/config.json Outdated
Comment thread types/fhirpath_test_engine.ts Outdated
Comment thread types/fhirpath_test_engine.ts Outdated
Comment thread types/fhirpath_test_engine.ts Outdated
Comment thread static/config.json Outdated
@brianpos

Copy link
Copy Markdown
Owner

I'm excited to see this get added!
Can you setup a static config file somewhere so we can test things out before it's properly included...
Details here:
https://github.com/brianpos/fhirpath-lab/blob/develop/docs/custom-configuration.md
Don't know if you want to include the early adopter flag.

Is this something that you think you'll have cooking for DevDays next week?
Would be a nice little surprise annoucenment at the meeting.

@jingtang10

Copy link
Copy Markdown

@LZRS can you add the static file simply in the github repo of the kotlin-fhirpath-server?

let's add early adopter flag first - but hopefully once it works we can remove.

@LZRS

LZRS commented Jul 7, 2026

Copy link
Copy Markdown
Author

@LZRS can you add the static file simply in the github repo of the kotlin-fhirpath-server?

let's add early adopter flag first - but hopefully once it works we can remove.

Yeah, the static config file was added to the GitHub repo and can be found here

@LZRS

LZRS commented Jul 8, 2026

Copy link
Copy Markdown
Author

@brianpos Apologies for the delay, here's a link to the static custom config for testing - https://35.246.242.55/kotlin-fhirpath-config.json

I've marked the PR as ready for review, so I'd love for you to check it out when you have a moment.

@LZRS
LZRS marked this pull request as ready for review July 8, 2026 11:02
@brianpos

Copy link
Copy Markdown
Owner

I've had a quick run through using your config file, that looks great.
The R5 engine was reporting status 500 errors, and the hackweek.fhirpath-lab.com server was getting CORS issues.
Are you going to use the IP address, or do you have a DNS entry that you'd rather be using?
@jingtang10

@jingtang10

Copy link
Copy Markdown

i think this is ready @brianpos thanks for taking a look!

@LZRS

LZRS commented Aug 19, 2026 •

Copy link
Copy Markdown
Author

I've had a quick run through using your config file, that looks great. The R5 engine was reporting status 500 errors, and the hackweek.fhirpath-lab.com server was getting CORS issues. Are you going to use the IP address, or do you have a DNS entry that you'd rather be using?

Thanks @brianpos. We now have a usable DNS entry fhirpath.ohs.dev and have addressed the issues on R5 engine and the hackweek.fhirpath-lab.com CORS.

The PR is ready, please give it another look

@LZRS

LZRS commented Aug 25, 2026

Copy link
Copy Markdown
Author

@brianpos Feel free to merge the PR or share new feedback in case there are changes to be made

@brianpos
brianpos merged commit 8b7309d into brianpos:develop Aug 26, 2026
2 of 4 checks passed
@brianpos

Copy link
Copy Markdown
Owner

@brianpos Feel free to merge the PR or share new feedback in case there are changes to be made

This was merged in and is in the hackweek build, but I have another unrelated build issue in the vue2 project that I'll be sorting in the next day or so blocking it from getting to dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants