Skip to content

Migrate ResourceEditor from Ace to Monaco with XML and FHIRPath/FML enhancements - #79

Draft
brianpos with Copilot wants to merge 9 commits into
developfrom
copilot/investigate-text-editor-switch
Draft

Migrate ResourceEditor from Ace to Monaco with XML and FHIRPath/FML enhancements#79
brianpos with Copilot wants to merge 9 commits into
developfrom
copilot/investigate-text-editor-switch

Conversation

Copilot AI commented May 21, 2026 •
edited
Loading

Copy link
Copy Markdown

ResourceEditor: narrower gutter + mobile touch support

  • lineNumbersMinChars: 3 and lineDecorationsWidth: 4 for a tighter default gutter
  • Collapse line numbers/folding/decorations when the editor container is narrower than 480 px (ResizeObserver, restored on grow, disconnected on unmount)
  • Option 1 — coarse-pointer friendly Monaco options (gated by window.matchMedia('(pointer: coarse)')):
    • Larger default font size (15 vs 14), mouseWheelZoom: true, fatter scrollbar.*ScrollbarSize (16 vs 10)
    • Disable popups that fight the on-screen keyboard: quickSuggestions, parameterHints, hover, acceptSuggestionOnEnter: 'off'
    • dragAndDrop: false always (touch drag should scroll, not move text)
    • touch-action: pan-y on the editor container for native vertical pan
    • Live update via media-query change listener (works across emulated/docked devtools too)
  • Option 2 — touch toolbar below the editor (only when pointer: coarse):
    • Undo / Redo / ↑ / ↓ / ← / → / Tab / Find / Format buttons wired through editor.trigger(...) and editor.getAction(...).run()
    • Vuetify v-btn icons consistent with the rest of ResourceEditor.vue
    • Toolbar hides automatically when the device reports a fine pointer; media-query listener is removed in onBeforeUnmount
  • npm run build in vue3-src succeeds

@github-actions

github-actions Bot commented May 21, 2026

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://yellow-plant-0209dde10-79.centralus.3.azurestaticapps.net

Copilot AI requested a review from brianpos May 21, 2026 23:02
@github-actions

github-actions Bot commented May 21, 2026

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://yellow-plant-0209dde10-79.centralus.3.azurestaticapps.net

@github-actions

github-actions Bot commented May 21, 2026

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://yellow-plant-0209dde10-79.centralus.3.azurestaticapps.net

@github-actions

github-actions Bot commented May 21, 2026

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://yellow-plant-0209dde10-79.centralus.3.azurestaticapps.net

@github-actions

github-actions Bot commented May 22, 2026

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://yellow-plant-0209dde10-79.centralus.3.azurestaticapps.net

@github-actions

github-actions Bot commented May 22, 2026

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://yellow-plant-0209dde10-79.centralus.3.azurestaticapps.net

@brianpos
Bump lineNumbersMinChars from 2 to 3
56f9b3a 
Agent-Logs-Url: https://github.com/brianpos/fhirpath-lab/sessions/6cb5323a-78d0-48b5-9475-1d6a8197ef88

Co-authored-by: brianpos <1557083+brianpos@users.noreply.github.com>
@github-actions

github-actions Bot commented May 22, 2026

Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://yellow-plant-0209dde10-79.centralus.3.azurestaticapps.net

@brianpos

brianpos commented Jul 15, 2026

Copy link
Copy Markdown
Owner

This was pure exploration, due to the limitations with mobile, I'll keep with the Ace editor, but good to have this research done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianpos brianpos Awaiting requested review from brianpos

Assignees

@brianpos brianpos

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brianpos