Skip to content

I replaced the $_SERVER['DOCUMENT_ROOT'] occurences#1

Open
simon-dt wants to merge 2 commits intobrendo:masterfrom
simon-dt:master
Open

I replaced the $_SERVER['DOCUMENT_ROOT'] occurences#1
simon-dt wants to merge 2 commits intobrendo:masterfrom
simon-dt:master

Conversation

@simon-dt
Copy link
Copy Markdown

Because $_SERVER['DOCUMENT_ROOT'] is evil and not to be built upon ;-)

It's in the tcpdf library, perhaps they have their own git repository where i should push a configurable document root solution.

Because $_SERVER['DOCUMENT_ROOT'] is evil and not to be built upon!
@brendo
Copy link
Copy Markdown
Owner

brendo commented Jul 20, 2011

Funnily enough it does have a git repo, it's just hosted on Sourceforge so collaboration isn't as seamless as it could be.

I have forward this pull request diff to the creator for inclusion.

@simon-dt
Copy link
Copy Markdown
Author

Yeah, i couldn't find it on github either.

The commit i sent is a symphony-only fix, it uses symphony's DOCROOT define so the tcpdf creator has to do this in another way like, say, adding a variable to their config file ..

@brendo
Copy link
Copy Markdown
Owner

brendo commented Jul 21, 2011

Doh, yeah oversight by me. The TCPDF library already has some checks in the config file, but you're correct, this particular commit doesn't need to be added to the actual library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants