I replaced the $_SERVER['DOCUMENT_ROOT'] occurences#1
Open
simon-dt wants to merge 2 commits intobrendo:masterfrom
simon-dt:master
Open
I replaced the $_SERVER['DOCUMENT_ROOT'] occurences#1simon-dt wants to merge 2 commits intobrendo:masterfrom simon-dt:master
simon-dt wants to merge 2 commits intobrendo:masterfrom
simon-dt:master
Conversation
Because $_SERVER['DOCUMENT_ROOT'] is evil and not to be built upon!
Owner
|
Funnily enough it does have a git repo, it's just hosted on Sourceforge so collaboration isn't as seamless as it could be. I have forward this pull request diff to the creator for inclusion. |
Author
|
Yeah, i couldn't find it on github either. The commit i sent is a symphony-only fix, it uses symphony's DOCROOT define so the tcpdf creator has to do this in another way like, say, adding a variable to their config file .. |
Owner
|
Doh, yeah oversight by me. The TCPDF library already has some checks in the config file, but you're correct, this particular commit doesn't need to be added to the actual library. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because $_SERVER['DOCUMENT_ROOT'] is evil and not to be built upon ;-)
It's in the tcpdf library, perhaps they have their own git repository where i should push a configurable document root solution.