Skip to content

More changes to CI and subsequent fixes#400

Merged
kaleidawave merged 22 commits intomasterfrom
more-ci-and-fixes
Oct 15, 2025
Merged

More changes to CI and subsequent fixes#400
kaleidawave merged 22 commits intomasterfrom
more-ci-and-fixes

Conversation

@kaleidawave
Copy link
Copy Markdown
Collaborator

@kaleidawave kaleidawave commented Oct 4, 2025

Aiming to fix: Issues with "no std" added in #374 around tests #399 and using String #389. Changed the CI to catch these issues. Modified examples and tests to run on different feature configurations.

Steps

  • Add --no-default-features checks to CI
  • Move StylesWriter to own module to avoid cfg repetition
  • Move term.rs to term/mod.rs to avoid confusion
  • Split emit to emit_to_string, emit_to_io_write and emit_to_write_style
  • Add emit_to_write_color function for termcolor::WriteColor
  • Update tests and get them working with --no-default-features
  • Change start_context_lines back to before_label_lines and revert expected test
  • Add CI "ecosystem" tests (warn if PR is tagged with breaking change)

@kaleidawave kaleidawave added tests A change to testing ci changes to the GitHub actions setup labels Oct 4, 2025
@kaleidawave kaleidawave marked this pull request as ready for review October 10, 2025 11:14
Copy link
Copy Markdown

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Will fix our problem!

@kaleidawave kaleidawave added the api Changes to the public facing API / exports label Oct 15, 2025
@kaleidawave kaleidawave merged commit 2d36d83 into master Oct 15, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Changes to the public facing API / exports ci changes to the GitHub actions setup tests A change to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants