More changes to CI and subsequent fixes#400
Merged
kaleidawave merged 22 commits intomasterfrom Oct 15, 2025
Merged
Conversation
cwfitzgerald
approved these changes
Oct 14, 2025
cwfitzgerald
left a comment
There was a problem hiding this comment.
Thanks for working on this! Will fix our problem!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aiming to fix: Issues with "no std" added in #374 around tests #399 and using
String#389. Changed the CI to catch these issues. Modified examples and tests to run on different feature configurations.Steps
--no-default-featureschecks to CIStylesWriterto own module to avoidcfgrepetitionterm.rstoterm/mod.rsto avoid confusionemittoemit_to_string,emit_to_io_writeandemit_to_write_styleemit_to_write_colorfunction fortermcolor::WriteColor--no-default-featuresstart_context_linesback tobefore_label_linesand revert expected test