Skip to content

feat/send-timer-notification#19

Merged
brendan-ch merged 13 commits into
mainfrom
feat/send-timer-notification
Jan 22, 2026
Merged

feat/send-timer-notification#19
brendan-ch merged 13 commits into
mainfrom
feat/send-timer-notification

Conversation

@brendan-ch

@brendan-ch brendan-ch commented Jan 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner
  • Add publishers to TimerContext indicating timer start/stop events
  • Add listener in app root to schedule notification on timer end, only if timer expired
  • In NotificationContext, check if permission was granted and schedule the notification
  • Add conversion of TimerMode to UNNotificationRequest
  • "Click" the status bar item when the notification is clicked
    • This way, the window retains menu bar window properties, such as closing itself when something else is clicked

Closes #9

@brendan-ch
Refactor TimerMode into its own "shared type"
857390e
@brendan-ch
Construct and test notification request from timer mode
5b0fb8f
@brendan-ch
Fix setting of starter object in TimerContext, and add a test for it
02bed66
@brendan-ch
Schedule the notification if the state has changed
270f3a7
@brendan-ch
Only emit the notification if the timer actually runs to completion
343bc67
@brendan-ch
Refactor timer states to only use one associated property per state
9bb0638 
- Only store .pending(let mode) and .running(let timeRemaining) in the state
- Store timer start metadata as a separate property (this also automatically makes it a publisher)
@brendan-ch
Publish lastTimerStopMetadata and use that to schedule the notification
973e535
@brendan-ch
Implement TimerMode.next() and set the next mode when the timer expires
eb18081
@brendan-ch
"Click" the status bar item on notification click
6afa402 
This approach may be re-used when implementing global keyboard shortcuts.
See https://stackoverflow.com/questions/74986904/how-do-i-show-the-menu-bar-window-programmatically-in-swiftui.
@brendan-ch
Fix failing test due to updated behavior of switching timer modes
e9c3034
@brendan-ch
Add timestamps to metadata structs
ca1e088 
This ensures that listeners of these properties will detect changes if the user decides to toggle another session of the same timer mode.
@brendan-ch
Check for permission before adding to notification center
f1f7842 
This avoids spamming the user with previously undelivered notifications if they grant permission later.
@brendan-ch brendan-ch self-assigned this Jan 22, 2026
@brendan-ch brendan-ch added the enhancement New feature or request label Jan 22, 2026
@brendan-ch
Remove recordedAt for TimerStartMetadata and add injection of recorde…
55dfc86 
…dAt for TimerStopMetadata

`start` is a suitable alternative in TimerStartMetadata.
@brendan-ch brendan-ch merged commit 89ab875 into main Jan 22, 2026
1 check passed
@brendan-ch brendan-ch deleted the feat/send-timer-notification branch January 22, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@brendan-ch brendan-ch

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Send timer notification if permission granted

1 participant

@brendan-ch