feat/notification-permissions#18
Merged
Merged
Conversation
…the current status
…"Grant notification permission" button
Reduce code duplication in requiring two environment functions
…se State instead of AppStorage UserDefaults is read once to set the state, and then a one-way sync is established from state to UserDefaults. For some reason AppStorage doesn't play well with app.launchArguments (seems like values just aren't updated?)
brendan-ch
commented
Jan 21, 2026
| } | ||
|
|
||
| private func updateMenuBarText() { | ||
| if case .running(let timeRemaining, _) = timerContext.state { |
Owner
Author
There was a problem hiding this comment.
in the future, add test case for menu bar text generation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8
Note: still needs UI test for the callout next to the timer