fix: package DeviceActivityReport extension as ExtensionKit to pass App Store validation

[brendan-ch]

Problem

App Store Connect validation (and Xcode Cloud, which runs the same archive → validate path) rejected the build because of the OpenAppLockReport DeviceActivityReport extension. There were two cascading errors:

1. Error 90349 — NSExtensionPointIdentifier was com.apple.deviceactivity.report-extension, which is invalid. The report extension point lives in DeviceActivityUI, so the identifier needs the ui: com.apple.deviceactivityui.report-extension. (The monitor extension's com.apple.deviceactivity.monitor-extension is correct and unaffected — the report value had been pattern-matched off it and dropped the ui.)
2. Error 91179 — once the identifier was corrected, validation reported the appex was "built like an NSExtension" but its extension point requires an ExtensionKit extension: it must live in Extensions/ and declare EXAppExtensionAttributes, not NSExtension in PlugIns/.

The second error was found empirically by fixing the first and re-validating.

Fix

Migrate OpenAppLockReport from a legacy PlugIns app-extension to an ExtensionKit extension:

• Info.plist: NSExtension/NSExtensionPointIdentifier → EXAppExtensionAttributes/EXExtensionPointIdentifier with the correct …ui… identifier (plus an explanatory comment to prevent regression).
• project.pbxproj:
  • product type com.apple.product-type.app-extension → com.apple.product-type.extensionkit-extension
  • file reference wrapper.app-extension → wrapper.extensionkit-extension
  • moved the .appex out of "Embed Foundation Extensions" (PlugIns, dstSubfolderSpec=13) into a new "Embed ExtensionKit Extensions" phase (Extensions, dstSubfolderSpec=16, dstPath=$(EXTENSIONS_FOLDER_PATH))

The @main DeviceActivityReportExtension SwiftUI entry point is unchanged and correct for both packagings; no principal class is added (the runtime rejects it for this extension point).

Test plan

• Archived OpenAppLock (Any iOS Device, arm64) in Xcode.
• Ran Product → Archive → Validate App against App Store Connect: "OpenAppLock 1.0.0 (1) validated — Your app successfully passed all validation checks."
• Confirmed the prior failing identifier error (90349) and the follow-on ExtensionKit error (91179) are both gone.
• (Informational) Local builds show a ValidateEmbeddedBinary warning about the Extensions embed path — a known Xcode tooling false-positive for correctly-configured ExtensionKit extensions (its validator mishandles the symlinked build layout). Server-side validation passing confirms the embedding is correct.

🤖 Generated with Claude Code

https://claude.ai/code/session_017CGu4VBWwg6he3zeZdLNGe