feat: view app lists read-only in Hard Mode#17
Merged
Conversation
While a Hard Mode rule is actively blocking, app lists were fully inert: their apps could not be viewed at all. Allow opening a list to view its apps read-only while keeping the "no editing" lock intact. - Add read-only AppListDetailView (apps + count + lock notice; no name field, Edit Apps, or Save). - Extract shared AppSelectionRows so the editor and the detail render a list's contents identically. - AppListLibraryView: locked rows open the read-only detail instead of being inert -- management rows tap in (with a chevron); the picker swaps "Edit" for "View". Unlocked behavior (full editor) is unchanged; Edit/Delete and the lock notice stay gated as before. - Update AGENT_RULES_FEATURE_SPEC section 3 to document view-while-locked. Covered by UI tests for management/picker x locked(read-only)/ unlocked(editor). Full suite: 243/243. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019u1fqx7a1QvWGJQPNZYSRz
main folded the Rules feature spec out of Docs/AGENT_RULES_FEATURE_SPEC.md into source doc comments + the AGENTS.md feature map (PR #16). Resolved the modify/delete conflict by accepting the file's deletion and re-expressing the view-app-lists-in-Hard-Mode documentation in the same folded style: the view-while-locked behavior now lives in the AppListLibraryView and AppListDetailView doc comments (the feature map already globs OpenAppLock/Views/AppLists/*). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019u1fqx7a1QvWGJQPNZYSRz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While a Hard Mode rule is actively blocking, app lists were fully inert — their apps couldn't be viewed at all. This lets the user open a list to view its apps read-only while keeping the "no editing" lock fully intact.
AppListDetailView(apps + count + lock notice; no name field, "Edit Apps", or Save).AppSelectionRowsso the editor and the read-only detail render a list's contents identically.AppListLibraryView: locked rows now open the read-only detail instead of being inert — management rows tap straight in (with a chevron); the picker swaps its "Edit" button for "View". Unlocked behavior (→ full editor) is unchanged; Edit/Delete and the lock notice stay gated exactly as before.AppListLibraryView/AppListDetailView), matching the spec-in-code layout from docs: fold the Rules feature spec into the codebase #16 (merged into this branch).Test plan
SettingsUITests/testUninstallProtectionToggleStartsOffAndFlips) is in a file this PR doesn't touch and passes in isolation — pre-existing XCUITest flakiness, not a regression.🤖 Generated with Claude Code
https://claude.ai/code/session_019u1fqx7a1QvWGJQPNZYSRz