feat: add GitHub and website links to Settings#14
Merged
Conversation
Add an "About" section to the Settings screen with GitHub and Website links. Both destinations are configurable via the OAL_GITHUB_URL / OAL_WEBSITE_URL user-defined build settings (Config/Shared.xcconfig) and read centrally through the new AppLinks accessor. Custom keys can't be injected into a generated Info.plist, so the build settings ride into the app through a partial OpenAppLock/Info.plist (OALGitHubURL / OALWebsiteURL), with a synchronized-group membership exception so the plist isn't double-produced. Verified red-green: unit tests cover AppLinks parsing and the full build-setting -> Info.plist pipeline; a UI test asserts each button opens the configured URL via an openURL interceptor, fed deterministic URLs through new -github-url= / -website-url= launch args. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
CONTRIBUTING.md no longer exists; remove the now-dangling pointers in the xcconfig setup comments and the AGENTS.md human-authored-docs example. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an About section to the Settings screen with GitHub and Website links. Both destinations are configuration, not code:
OAL_GITHUB_URL/OAL_WEBSITE_URLuser-defined build settings inConfig/Shared.xcconfig,OpenAppLock/Info.plist, and read at runtime through a single central accessor,AppLinks.Swap either link by editing the build settings — no code change. The website value is a placeholder until the site exists. Links are plain text (no icons) to keep the section low-key; a link is omitted when its URL is unset/blank, and the whole section drops when neither is configured.
Implementation notes
INFOPLIST_KEY_*settings are not injected into a generated Info.plist, so the values ride through a real partial plist (INFOPLIST_FILE+GENERATE_INFOPLIST_FILE=YESmerge), with a synchronized-group membership exception soInfo.plistisn't double-produced.//as a comment, so the URLs use a$(SLASH)indirection to spell://.Testing
AppLinkspure parsing and the full build-setting → Info.plist → runtime pipeline (the app-hosted test reads the real bundle)LaunchConfigurationlink-override parsingtestAboutLinksOpenConfiguredURLstaps each button and asserts it opens the configured URL via anopenURLinterceptor, fed deterministic URLs through new-github-url=/-website-url=launch argsmainAlso drops now-dangling
CONTRIBUTING.mdreferences (file removed).🤖 Generated with Claude Code