Skip to content

Fix TypeError in spawnSync output properties handling #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
breakingthebot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix TypeError in spawnSync output properties handling #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/services/githubSyncService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ function fetchPublicRepositories(owner) {
},
);

if (result.status !== 0) {
if (result.status !== 0 || result.error) {
const stderr = typeof result.stderr === "string" ? result.stderr.trim() : "";
const stdout = typeof result.stdout === "string" ? result.stdout.trim() : "";
const processError =
Expand Down
2 changes: 1 addition & 1 deletion src/services/releaseDayService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function runCommand(command, args) {
encoding: "utf8",
});

if (result.status !== 0) {
if (result.status !== 0 || result.error) {
const stderr = typeof result.stderr === "string" ? result.stderr.trim() : "";
const stdout = typeof result.stdout === "string" ? result.stdout.trim() : "";
const processError =
Expand Down
11 changes: 8 additions & 3 deletions src/services/trackerSyncService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,18 @@ function runPowerShellScript(script) {
encoding: "utf8",
});

if (result.status !== 0) {
if (result.status !== 0 || result.error) {
const stderr = typeof result.stderr === "string" ? result.stderr.trim() : "";
const stdout = typeof result.stdout === "string" ? result.stdout.trim() : "";
const processError =
result.error && result.error.message ? result.error.message : "";

throw new Error(
result.stderr.trim() || result.stdout.trim() || "PowerShell script failed.",
processError || stderr || stdout || "PowerShell script failed.",
);
}

return result.stdout.trim();
return typeof result.stdout === "string" ? result.stdout.trim() : "";
}

/**
Expand Down
Loading