fix superfluous comma in flow mappings

[Fidelxyz]

When a flow mapping ends in non-canonical mode, the emitter no longer writes a trailing comma before the closing } merely because comments are pending.

The comma was a leftover from upstream (117fdf0) and is unnecessary: pending foot comments are emitted after }, and head/tail comments always start on a new line. This makes flow mappings consistent with flow sequences, which already only emit the trailing comma in canonical mode.

Also fixes google/yamlfmt#110 and google/yamlfmt#195.

[ccoVeille]

Hi @Fidelxyz

I'm one of the maintainer of yaml/go-yaml a fork maintained by YAML organization & community to replace the discontinued go-yaml/yaml repository that was used to create braydonk/yaml

The v3 branch of yaml/go-yaml is a pure fork of go-yaml/yaml.

I'm curious if you could confirm if the bug you faced here also affects yaml/go-yaml if so we will create a fix in the main branch (the current v4)

cc @ingydotnet

[Fidelxyz]

@ccoVeille I conform that the bug also affects yaml/go-yaml.

[ccoVeille]

@Fidelxyz do you think you cool open an issue on https://github.com/yaml/go-yaml then?

While I understand there is an issue, I don't get what how to replicate the issue out of yamlfmt

Also, I can see @sidsri14 opened

google/yamlfmt#323

He might be interested.

[ccoVeille]

I created it yaml/go-yaml#405

• Flow mapping with foot comment has no superfluous comma yaml/go-yaml#405