Skip to content

feat: add custom threshold badges - #294

Merged
brandtnewlabs merged 1 commit into
mainfrom
codex/custom-threshold-badge
Aug 26, 2026
Merged

feat: add custom threshold badges#294
brandtnewlabs merged 1 commit into
mainfrom
codex/custom-threshold-badge

Conversation

@brandtnewlabs

@brandtnewlabs brandtnewlabs commented Aug 25, 2026

Copy link
Copy Markdown
Owner

Summary

  • add LiveChart.renderThresholdBadge for custom React Native threshold badges
  • expose live threshold value, formatted value, Y position, visibility, and resolved line config through ThresholdBadgeRenderProps
  • preserve the built-in Skia badge when the renderer returns null/undefined, while keeping the dashed marker line native
  • document the API and add a realistic average-cost badge to the Threshold example

Verification

  • npm run verify — 106 suites passed; 1,596 tests passed, 5 skipped
  • React Doctor — 96/100 (two pre-existing maintainability warnings, no errors)
  • iOS example app verified with agent-device; recording attached in the PR comments

Closes #291

Copy link
Copy Markdown
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@brandtnewlabs

Copy link
Copy Markdown
Owner Author

iOS example app proof

The recording shows the built-in threshold pill switching to the custom React Native B/E badge. The chart and formatted value keep updating live, and the badge then moves from the configured left anchor to the right anchor while the native dashed threshold line remains in place.

issue-291-custom-threshold-proof.mp4

@brandtnewlabs
brandtnewlabs force-pushed the codex/custom-threshold-badge branch from f9d7e63 to 5d85a20 Compare August 26, 2026 07:22
@brandtnewlabs
brandtnewlabs merged commit 080f304 into main Aug 26, 2026
5 checks passed
@brandtnewlabs
brandtnewlabs deleted the codex/custom-threshold-badge branch August 26, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: custom threshold badge

1 participant