Skip to content

feat: add threshold badge anchor - #293

Merged
brandtnewlabs merged 1 commit into
mainfrom
codex/threshold-label-anchor
Aug 26, 2026
Merged

feat: add threshold badge anchor#293
brandtnewlabs merged 1 commit into
mainfrom
codex/threshold-label-anchor

Conversation

@brandtnewlabs

@brandtnewlabs brandtnewlabs commented Aug 25, 2026

Copy link
Copy Markdown
Owner

Summary

  • add threshold.line.labelAnchor for time-varying threshold badges
  • keep "last" as the backward-compatible default; "first" anchors the badge to the visible window's left edge
  • update the public API docs, changelog, tests, and threshold example controls

Verification

  • npm run verify
  • 105 test suites passed
  • 1,593 tests passed and 5 skipped
  • verified both anchors in the iOS example app with agent-device

Closes #292

Video

A simulator recording showing Last and First anchor behavior is attached in the PR discussion below.

Copy link
Copy Markdown
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@brandtnewlabs

Copy link
Copy Markdown
Owner Author

Simulator proof

The example app switches from the backward-compatible Last anchor to the new First anchor. The threshold badge immediately moves to the value at the left edge of the visible window while the chart continues streaming.

issue-292-proof-trimmed.mp4

@brandtnewlabs
brandtnewlabs force-pushed the codex/threshold-label-anchor branch from af22f29 to 9d60297 Compare August 26, 2026 07:14
@brandtnewlabs
brandtnewlabs merged commit ef64298 into main Aug 26, 2026
5 checks passed
@brandtnewlabs
brandtnewlabs deleted the codex/threshold-label-anchor branch August 26, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Allow anchor configurability for threshold badge

1 participant