fix: ENG-6379 - code-app-env - DataView perf #2866
Open
UncleClapton wants to merge 13 commits into
Open
Conversation
d527314 to
ca30fa9
Compare
…dev screen generator
1761201 to
84d0c23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
The following changes have been made to
code-app-env:CodeBlocks now display Line numbers for easier referenceDataViews can now parse deeply nested JSON strings within provided data. This is optional, and controllable via prop.DataViewactions may now be disabled viadisabledoption.AsyncStorageDevScreenandSensitiveInfoDevScreenhave been abstracted to a commonDataViewerDevScreenwhich provides an easy way to define data viewer screens for other libraries, such asreact-native-keychain.AsyncStorageDevScreennow accepts new options, and a generator function has been created to bind these props to the screen.parseValues- under the hood, enablesdeepParsefor the data view. Practically, enables parsing of AsyncStorage values that are detected to be objects or arraysdisplayKeyFilter- Controls which keys may be displayed in the data viewer. This provides a final fallback solution in the event the app has a key/value pair that either breaks the screen, or just shouldn't be displayed outright.clearKeyFilter- Controls which keys may be cleared when cleared via CTA. Mainly provided for completeness sake withdisplayKeyFilter. I didn't want to have one prop that affects both.CodeBlockdisplaying massive text strings. instead, we split content into text lines which are individually rendered in an optimizedFlatList.DataView.Issue ticket number and link
ENG-6379
Type of change
Please delete options that are not relevant.
Test Plan
AsyncStorage.Checklist before requesting a review