Fix test that failed due to reliance on randomness#631
Merged
Conversation
alessandrofelder
approved these changes
Jul 13, 2026
alessandrofelder
left a comment
alessandrofelder
left a comment
Member
There was a problem hiding this comment.
Thanks @matham - I just had a test spuriously fail for this reason on a different PR which motivated me to get this merged sooner 😂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
To test that cube normalization worked, I had a test that created a volume using a normal distribution and then I tested that after normalization the mean was zero and std was 1, within some bounds. The problem is that this test failed in this unrelated PR https://github.com/brainglobe/cellfinder/actions/runs/27896437125/job/82548769409?pr=628. That's because when taking cuboids of the volume, their mean/std was out of the testing bounds simply due to randomness leading to test failure.
What does this PR do?
This creates the volume without relying on randomness, making it so that every cuboid should have similar mean/std. We do it by alternating the values around the mean by +/- std.
References
https://github.com/brainglobe/cellfinder/actions/runs/27896437125/job/82548769409?pr=628
How has this PR been tested?
The test works.
Is this a breaking change?
No.
Does this PR require an update to the documentation?
No.
Checklist: