Pass cell metadata through napari.#629
Open
matham wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
Previously we added support for round-tripping cell metadata through Napari via brainglobe/brainglobe-napari-io#102. However, within Cellfinder itself we also add cell layers and convert layers to
Cells. The code within cellfinder did not have support for round-tripping cell metadata.What does this PR do?
This adds support for round-tripping the cell metadata, similar to that PR. Ideally this may all happen perhaps in brainglobe-utils? But for now it's not a lot of changes so I kept things simple and just added the fix here.
References
brainglobe/brainglobe-napari-io#102.
How has this PR been tested?
Locally in typical use as well as added test.
Is this a breaking change?
No.
Does this PR require an update to the documentation?
No.
Checklist: