Repository navigation
The line of a sound in the text, as Pages 15.4 makes it (B-025, W1 step 17) - #180
Merged
Merged
Conversation
Pages 15.4 gives the line of a sound in the text 7.23 points of room over the sound, which stands on the baseline under it; a movie takes only its own height. obj-18-audio-video now compares with the PDF of Pages 15.4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NiPLVSJ4urMWCnygLAWw8C
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Brahm · project thread
The first piece of step 17 of docs/phases/W1.md.
B-020 was already done in #147, together with B-021 (step 18). Step 17 is left with B-022 to B-025.
What changes
obj-18-audio-videothat Pages 15.4 exports, the line of the inline sound (53 pt high) is 7.23 pt taller than the sound. The inline movie takes only its own height.inline_sizesin desk-layout now gives a sound its height plus 7.23 pt. The sound still stands on the baseline, with the extra room above it.obj-18-audio-video.pdfis replaced with the PDF of Pages 15.4, and the manifest says so.The words differed by 6.4 pt before this change. Now the test passes within the usual tolerance.
Not verified
The PDF holds only one sound, so I can't tell whether Pages adds a fixed 7.23 pt or adds in proportion to the sound's size. The constant is a measurement from that one PDF. This goes on the list for the Mac in step 19, with a sound of another size.
Tests
Generated by Claude Code