Skip to content

Add-ons: compatible with 1.0.0-rc1, Import closes race/class combinations - #87

Merged
brahm merged 1 commit into
mainfrom
claude/project-thread-h1syal
Oct 24, 2026
Merged

brahm merged 1 commit into
mainfrom
claude/project-thread-h1syal

Conversation

@brahm

@brahm brahm commented Oct 24, 2026

Copy link
Copy Markdown
Owner

Requested by Brahm · project thread

Brings the Community Add-ons Collection up to date with 1.0.0-rc1. Once merged, the Addons package workflow publishes the new installer on GitHub Packages as corerules-community-addons:1.0.0-rc1 and latest.

Changes

  • Import fixes race/class combinations in one pass (cr-store). A combination that names two classes from the package used to come in only on a second import, as in the original. The app's Import showed 304 false "No race/class combinations could be added" warnings for Comunidade.xpx. After the import, the classes it brought in now get a second round using the in-memory class list, and only combinations that still fail are reported. Result: 36 warnings, all for races the package ships without combinations. The databases are byte-for-byte identical to the old two-pass install, and .bak now holds the pre-import file.
  • Installer imports once (cr-addons), with a test (it needs CORERULES_DIR) that checks one import resolves every combination and that re-importing the classes changes nothing.
  • Package data: the class Sword Dancer (trailing space) and its 5 mentions with the space become Sword Dancer. That is how Qilué Veladorn and the package's other 90 mentions spell it, so her sheet and Edit Character used to refuse to open her. Both whole packages were parsed and compared, and nothing else changed. Comunidade-extras.xz was updated to match.
  • README, GUIA and relatório updated.

Verification (with a clean Expansion data package)

  • cr import and the app's Import window: 36,525 items, no crash.
  • All 36,207 user records went through the editors field by field and were saved. None were refused.
  • All 48 characters open as sheets (txt/html/md), and edit and save fine. Qilué also opens in Edit Character and saves in the GUI.
  • The installer AppImage window installed the add-ons in 22 s, with the same databases as the app's Import.
  • cargo fmt --check, clippy -D warnings and cargo test --workspace all pass.

Note: the golden test import_leaves_what_the_original_left (it needs goldens that aren't available here) could differ if its package has classes that name each other, because the original needed a second import for those.


Generated by Claude Code

…ions

The app's Import now brings in, in one go, the race/class combinations
that name two classes of the package: after the import the classes go
round again with the ones it brought in, and only what still fails is
reported. Importing Comunidade.xpx in the app went from 340 warnings to
the 36 races the package has no combinations for, and leaves the same
databases, byte for byte, as the two passes the installer made, which
now imports once.

The class Sword Dancer came in as "Sword Dancer " with a trailing space,
while Qilué Veladorn and the package's other 90 mentions name it
without, so her sheet and Edit Character refused to open. The class and
its five spaced mentions lose the space; nothing else in the package
changes.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016gR4NzQX63exts7wKH4bWD
@brahm brahm self-assigned this Oct 24, 2026
@brahm
brahm merged commit 0314c06 into main Oct 24, 2026
2 checks passed
brahm pushed a commit that referenced this pull request Oct 24, 2026
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NxAxj5qNLtfagz6aKe9YQp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants