Repository navigation
Add-ons: compatible with 1.0.0-rc1, Import closes race/class combinations - #87
Merged
Merged
Conversation
…ions The app's Import now brings in, in one go, the race/class combinations that name two classes of the package: after the import the classes go round again with the ones it brought in, and only what still fails is reported. Importing Comunidade.xpx in the app went from 340 warnings to the 36 races the package has no combinations for, and leaves the same databases, byte for byte, as the two passes the installer made, which now imports once. The class Sword Dancer came in as "Sword Dancer " with a trailing space, while Qilué Veladorn and the package's other 90 mentions name it without, so her sheet and Edit Character refused to open. The class and its five spaced mentions lose the space; nothing else in the package changes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016gR4NzQX63exts7wKH4bWD
brahm
pushed a commit
that referenced
this pull request
Oct 24, 2026
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NxAxj5qNLtfagz6aKe9YQp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Brahm · project thread
Brings the Community Add-ons Collection up to date with 1.0.0-rc1. Once merged, the
Addons packageworkflow publishes the new installer on GitHub Packages ascorerules-community-addons:1.0.0-rc1andlatest.Changes
cr-store). A combination that names two classes from the package used to come in only on a second import, as in the original. The app's Import showed 304 false "No race/class combinations could be added" warnings forComunidade.xpx. After the import, the classes it brought in now get a second round using the in-memory class list, and only combinations that still fail are reported. Result: 36 warnings, all for races the package ships without combinations. The databases are byte-for-byte identical to the old two-pass install, and.baknow holds the pre-import file.cr-addons), with a test (it needsCORERULES_DIR) that checks one import resolves every combination and that re-importing the classes changes nothing.Sword Dancer(trailing space) and its 5 mentions with the space becomeSword Dancer. That is how Qilué Veladorn and the package's other 90 mentions spell it, so her sheet and Edit Character used to refuse to open her. Both whole packages were parsed and compared, and nothing else changed.Comunidade-extras.xzwas updated to match.Verification (with a clean Expansion data package)
cr importand the app's Import window: 36,525 items, no crash.cargo fmt --check,clippy -D warningsandcargo test --workspaceall pass.Note: the golden test
import_leaves_what_the_original_left(it needs goldens that aren't available here) could differ if its package has classes that name each other, because the original needed a second import for those.Generated by Claude Code