Repository navigation
Add-ons installer: find Core Rules on its own, in the app's six languages - #12
Merged
Merged
Conversation
The installer now looks for the app however it was installed (Flatpak, .deb, .rpm or an AppImage in the usual folders) and installs into the data folder each copy reads, falling back to the Wine prefix as the app does. "Other Folder…" stays for anything it cannot find, and "Open Core Rules" starts the copy that was found. Its window now speaks the app's six languages through cr-i18n and follows the language chosen in the app's Preferences (native or Flatpak), else the system's. The backup folder is now data-before-addons-STAMP. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V1HBxYSKFxuBSED6FSFH5j
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Brahm · project thread
Before: the add-ons installer showed one data folder, the one
Installation::discoverpicked, and asked the user to choose another with Escolher…. A Flatpak install, whose data lives under~/.var/app, was never found. The window was Portuguese only.After: the installer finds every copy of Core Rules on the computer, whether it came as the Flatpak (user or system), the .deb or .rpm package, or an AppImage in the usual folders, and lists each with the data folder it reads, falling back to the Wine prefix as the app does. It installs into each distinct folder once, offers Open Core Rules when a copy has no game data yet (so the user can run Extract Data from CD…), and keeps Other Folder… for anything it can't find. The window speaks the app's six languages and follows the language chosen in the app's Preferences (native or Flatpak settings), else the system's.
How: new
crates/cr-addons/src/locate.rsdoes the detection (Flatpak metainfo,/var/lib/dpkg/info/corerules.list,rpm -qf, AppImage file names) and launches the found copy with the AppImage's own environment stripped. All texts go throughcr-i18n, with 46 new entries translated in every catalog; numbers are grouped per language. The desktop file gains es/it/fr/de names, the backup folder is nowdata-before-addons-STAMP, and both READMEs describe detection and languages.Tested under Xvfb with the real v0.8.0 .deb and AppImage, a simulated Flatpak, a Wine-only setup and no install at all, and the window in German, French, Spanish, Italian and English, including a full install in Italian (36,716 items, 105 characters).
Generated by Claude Code