Skip to content

Add-ons installer: find Core Rules on its own, in the app's six languages - #12

Merged
brahm merged 1 commit into
mainfrom
claude/community-addons-d72yc0
Oct 19, 2026
Merged

brahm merged 1 commit into
mainfrom
claude/community-addons-d72yc0

Conversation

@brahm

@brahm brahm commented Oct 19, 2026

Copy link
Copy Markdown
Owner

Requested by Brahm · project thread

Before: the add-ons installer showed one data folder, the one Installation::discover picked, and asked the user to choose another with Escolher…. A Flatpak install, whose data lives under ~/.var/app, was never found. The window was Portuguese only.

After: the installer finds every copy of Core Rules on the computer, whether it came as the Flatpak (user or system), the .deb or .rpm package, or an AppImage in the usual folders, and lists each with the data folder it reads, falling back to the Wine prefix as the app does. It installs into each distinct folder once, offers Open Core Rules when a copy has no game data yet (so the user can run Extract Data from CD…), and keeps Other Folder… for anything it can't find. The window speaks the app's six languages and follows the language chosen in the app's Preferences (native or Flatpak settings), else the system's.

How: new crates/cr-addons/src/locate.rs does the detection (Flatpak metainfo, /var/lib/dpkg/info/corerules.list, rpm -qf, AppImage file names) and launches the found copy with the AppImage's own environment stripped. All texts go through cr-i18n, with 46 new entries translated in every catalog; numbers are grouped per language. The desktop file gains es/it/fr/de names, the backup folder is now data-before-addons-STAMP, and both READMEs describe detection and languages.

Tested under Xvfb with the real v0.8.0 .deb and AppImage, a simulated Flatpak, a Wine-only setup and no install at all, and the window in German, French, Spanish, Italian and English, including a full install in Italian (36,716 items, 105 characters).


Generated by Claude Code

The installer now looks for the app however it was installed (Flatpak,
.deb, .rpm or an AppImage in the usual folders) and installs into the data
folder each copy reads, falling back to the Wine prefix as the app does.
"Other Folder…" stays for anything it cannot find, and "Open Core Rules"
starts the copy that was found.

Its window now speaks the app's six languages through cr-i18n and follows
the language chosen in the app's Preferences (native or Flatpak), else the
system's. The backup folder is now data-before-addons-STAMP.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01V1HBxYSKFxuBSED6FSFH5j
@brahm
brahm merged commit 2de888c into main Oct 19, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants