Repository navigation
Extract Data from CD… inside the app, and release 0.8.0 - #10
Merged
Merged
Conversation
The app now copies what it uses out of a Core Rules 2.0 or Expansion CD itself, from the CD's ISO image (read in Rust, no mounting or tools), the mounted CD, an installation or a Wine prefix, as packaging/extract-data.sh did. The main menu and the start page offer it, and `cr extract-data` does the same from the command line. The output matches the script's file for file on both CDs and on a Wine installation. The data goes into the app's data folder, or next to it when taken; the Expansion takes the folder over from 2.0 data, which moves aside. Files are written writable, where the script's copies from a mounted CD kept the CD's read-only permissions. extract-data.sh is removed and the add-ons package no longer ships it: its static cr extracts the data instead. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KmpNaiS4AaK33AgTjZzqv1
Only the lines that name the removed extract-data.sh change in packaging/addons/build.sh and the add-ons workflow; the add-ons guide and installer are being replaced separately. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KmpNaiS4AaK33AgTjZzqv1
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KmpNaiS4AaK33AgTjZzqv1
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KmpNaiS4AaK33AgTjZzqv1
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KmpNaiS4AaK33AgTjZzqv1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Brahm · project thread
Before: to run without the CD or Wine, the user had to run
packaging/extract-data.shon an installation or a mounted CD and unpack the result into the app's data folder.After: the main menu and the "No Core Rules Installation" page offer Extract Data from CD…. It takes the CD's ISO image directly, or the folder of a mounted CD, an installation or a Wine prefix, copies the data into
~/.local/share/corerules/dataand opens it.cr extract-data SOURCE [DEST_DIR]does the same from the command line.extract-data.shis removed. The version goes to 0.8.0 (README, release notes, metainfo, rpm spec); taggingv0.8.0after the merge publishes the release.The output matches the script's file for file (only README.txt differs: its source line and its wording) on both CDs' ISO images, on the same CDs extracted as Linux mounts them, and on a Wine installation.
How:
cr-storegets a small ISO 9660 reader (iso9660.rs, Joliet when present, else plain names shown as a Linux mount shows them) andextract.rs, which ports the script's choices (Database/UserDbas/Chars, Books, Tables, the two program files, Help/*.cnt,.bakfiles left out) and writes into a staging folder renamed into place. When the data folder is taken, the package goes next to it; Expansion data takes the folder over from 2.0 data, which moves aside, since the Expansion is where the app writes. Files are written fresh, so copies from a read-only CD stay writable (the script'scp -Rkept the CD's read-only modes). New texts are translated in the five catalogs. Main (the add-ons installer app, #11) is merged in, and the release notes mention it.🤖 Generated with Claude Code
https://claude.ai/code/session_01KmpNaiS4AaK33AgTjZzqv1