Skip to content

Revert TypeScript 7, block it in Renovate for collection-reviewer-web - #34

Merged
bradwindy merged 2 commits into
mainfrom
revert-typescript-7
Jul 19, 2026
Merged

bradwindy merged 2 commits into
mainfrom
revert-typescript-7

Conversation

@bradwindy

@bradwindy bradwindy commented Jul 19, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Reverts chore(deps): update dependency typescript to v7 #30 (typescript 6→7 bump) — it merged with green CI, but the CI/CD workflow doesn't run any job against collection-reviewer-web, so the break went unnoticed.
  • Confirmed locally: with TypeScript 7, Next.js fails to detect TypeScript despite it being installed, and the build worker crashes with The "id" argument must be of type string. Received undefined.
  • Adds a renovate.json packageRule disabling TypeScript major-version updates until this is fixed upstream (same pattern used in nz-speed-cameras for the identical TS7/Next.js incompatibility).

Test plan

  • npm ci && npm run build in collection-reviewer-web succeeds with TypeScript reverted to ^6.0.0
  • npm test (vitest) passes — 20/20
  • renovate.json is valid JSON

🤖 Generated with Claude Code

https://claude.ai/code/session_0123CpP5bgD18myWDPZ8Emhh

Summary by CodeRabbit

  • Chores
    • Updated the TypeScript development version for improved compatibility.
    • Configured dependency updates to defer automatic TypeScript major-version upgrades until compatibility is confirmed.

bradwindy and others added 2 commits July 19, 2026 16:15
TypeScript 7 breaks collection-reviewer-web's Next.js build: Next fails
to detect TypeScript despite it being installed, and the build worker
crashes with "The id argument must be of type string. Received
undefined". Confirmed by running the actual build locally - this
repo's CI does not have a job covering collection-reviewer-web, so the
break did not show up as a failing check on the PR that bumped it.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0123CpP5bgD18myWDPZ8Emhh
@coderabbitai

coderabbitai Bot commented Jul 19, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ff7bbe6d-00e7-4ab6-8bbb-5aeebc270d4e

📥 Commits

Reviewing files that changed from the base of the PR and between 6a8c927 and bf490db.

⛔ Files ignored due to path filters (1)
  • collection-reviewer-web/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • collection-reviewer-web/package.json
  • renovate.json
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • bradwindy/RichError (auto-detected)

📝 Walkthrough

Walkthrough

TypeScript in the web package was changed from ^7.0.0 to ^6.0.0. Renovate now disables automated major TypeScript updates pending manual compatibility confirmation.

Changes

TypeScript compatibility

Layer / File(s) Summary
TypeScript version and update policy
collection-reviewer-web/package.json, renovate.json
The web package uses TypeScript ^6.0.0, and Renovate major updates for TypeScript are disabled with a compatibility note.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: dependencies

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the TypeScript downgrade and the Renovate rule blocking future major updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-typescript-7
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch revert-typescript-7

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added the dependencies Pull requests that update a dependency file label Jul 19, 2026
@bradwindy
bradwindy merged commit f6f9d4e into main Jul 19, 2026
4 checks passed
@bradwindy
bradwindy deleted the revert-typescript-7 branch July 19, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant