Repository navigation
Revert TypeScript 7, block it in Renovate for collection-reviewer-web - #34
Merged
Merged
Conversation
This reverts commit 6a8c927.
TypeScript 7 breaks collection-reviewer-web's Next.js build: Next fails to detect TypeScript despite it being installed, and the build worker crashes with "The id argument must be of type string. Received undefined". Confirmed by running the actual build locally - this repo's CI does not have a job covering collection-reviewer-web, so the break did not show up as a failing check on the PR that bumped it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0123CpP5bgD18myWDPZ8Emhh
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
📝 WalkthroughWalkthroughTypeScript in the web package was changed from ChangesTypeScript compatibility
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typescript6→7 bump) — it merged with green CI, but the CI/CD workflow doesn't run any job againstcollection-reviewer-web, so the break went unnoticed.The "id" argument must be of type string. Received undefined.renovate.jsonpackageRule disabling TypeScript major-version updates until this is fixed upstream (same pattern used in nz-speed-cameras for the identical TS7/Next.js incompatibility).Test plan
npm ci && npm run buildincollection-reviewer-websucceeds with TypeScript reverted to^6.0.0npm test(vitest) passes — 20/20renovate.jsonis valid JSON🤖 Generated with Claude Code
https://claude.ai/code/session_0123CpP5bgD18myWDPZ8Emhh
Summary by CodeRabbit