Conversation
maintner previously mirrored issue comments (the top-level conversation)
and PR review summaries, but not the review comments left on lines of a
PR's diff (GitHub's pulls/{number}/comments API). Consumers re-presenting
PR data therefore silently lacked all line-level review feedback.
Add a new GithubReviewComment mutation type carrying the comment's body,
author, parent review, reply threading, file path, commit IDs, diff-hunk,
and line/side position. Unlike issue comment mutations, each mutation is
a full snapshot applied wholesale: review comments are mutable and their
position fields shift (including to unset) as the PR is updated, which
field-presence patching can't represent.
Sync walks comments in updated-time order with the corpus's high-water
mark as an incremental cursor (like issue comments), picking up both new
comments and edits; deletions are not detected, matching the existing
issue comment limitation. The new ReviewComments sync category is on by
default. Review comment activity also now feeds GitHubIssue.LastModified,
and GitHubIssue.ForeachReviewComment exposes the data to consumers.
raggi
force-pushed
the
raggi/review-comments
branch
from
September 29, 2026 17:24
e28cef7 to
7c1059f
Compare
bradfitz
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maintner previously mirrored issue comments (the top-level conversation) and PR review summaries, but not the review comments left on lines of a PR's diff (GitHub's pulls/{number}/comments API). Consumers re-presenting PR data therefore silently lacked all line-level review feedback.
Add a new GithubReviewComment mutation type carrying the comment's body, author, parent review, reply threading, file path, commit IDs, diff-hunk, and line/side position. Unlike issue comment mutations, each mutation is a full snapshot applied wholesale: review comments are mutable and their position fields shift (including to unset) as the PR is updated, which field-presence patching can't represent.
Sync walks comments in updated-time order with the corpus's high-water mark as an incremental cursor (like issue comments), picking up both new comments and edits; deletions are not detected, matching the existing issue comment limitation. The new ReviewComments sync category is on by default. Review comment activity also now feeds GitHubIssue.LastModified, and GitHubIssue.ForeachReviewComment exposes the data to consumers.