Conversation
bcreane
force-pushed
the
bcreane/issue-field-event-history
branch
from
August 9, 2026 23:15
e4b6f2a to
8f7584e
Compare
Contributor
Author
|
okay, did another round of reviews and stripped out 30% of the code and 40% of the tests. @bradfitz if you've already looked at this PR and <shuddered>, it may be worth another glance. |
bradfitz
reviewed
Aug 28, 2026
The issue field values synced in 7e57545 are a snapshot of current state, so the value a field held at any past time is unrecoverable. Store GitHub's issue-field timeline events alongside them, accumulated in Created order and deduped by node ID rather than replaced wholesale, so callers can measure how long an issue sat at a given value. They ride along on the existing per-issue GraphQL query at no extra rate-limit cost. Signed-off-by: Brendan Creane <bcreane@gmail.com>
bcreane
force-pushed
the
bcreane/issue-field-event-history
branch
from
August 28, 2026 20:56
8f7584e to
10bdbc6
Compare
Contributor
Author
|
@bradfitz if this fell off your list ... |
Contributor
Author
|
Closing this in favor of #7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue field values synced in 7e57545 are a snapshot of current state, so the value a field held at any past time is unrecoverable. Store GitHub's issue-field timeline events alongside them, keyed by node ID and accumulated rather than replaced wholesale, so callers can measure how long an issue sat at a given value. They ride along on the existing per-issue GraphQL query at no extra rate-limit cost.