Fix linting errors from eslint-plugin-react-hooks v7 upgrade#456
Closed
Copilot wants to merge 3 commits into
Closed
Fix linting errors from eslint-plugin-react-hooks v7 upgrade#456Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
1 task
|
|
Co-authored-by: barmac <28307541+barmac@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Update dependency eslint-plugin-react-hooks to v7
Fix linting errors from eslint-plugin-react-hooks v7 upgrade
Nov 18, 2025
536d558 to
f112640
Compare
f112640 to
3a99430
Compare
3a99430 to
bb13264
Compare
bb13264 to
3305974
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v7 upgrade introduces stricter rules around ref access, mutations, and component creation during render. All violations have been addressed while preserving existing behavior.
Changes by category
Ref access during render
useElementVisible,useStickyIntersectionObserver: Accept refs instead ofref.currentFeel.js(5 instances),FeelEditor.js,TemplatingEditor.js: Wrap ref assignments inuseEffectTooltip.js: Move position calculation to state withuseEffectDropdownButton.js: Pass refs touseGlobalClick, dereference inside effectRef naming convention
Refsuffix per v7 hint:timeout→timeoutRefinTooltip.jsisAutoCompletionOpen→isAutoCompletionOpenRefinFeelPopup.jscontext→contextRefinPopup.jsisMounted→isMountedRefinPropertiesPanel.jsfocus→focusRefinuseShowEntryEvent.jsdidMount→didMountRefinuseEvent.jsHook rewrites
usePrevious: Use state + ref to avoid returningref.currentduring renderuseEvent: Simplify to effect-only subscription (remove immediate subscription pattern)useStaticCallback: MovecallbackRef.currentassignment touseEffectComponent creation
Header.js: Memoize icon element creation instead of component referenceExample fix pattern
Before (v6):
After (v7):
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.