Align GCS Client configuration with patterns established in S3 Client#1056
Merged
wadimw merged 1 commit intoupstream-patchedfrom Feb 16, 2026
Merged
Align GCS Client configuration with patterns established in S3 Client#1056wadimw merged 1 commit intoupstream-patchedfrom
wadimw merged 1 commit intoupstream-patchedfrom
Conversation
wadimw
added
the
upstream-patched
jaknas
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates GCS Blob Storage configuration to better match the existing setup for S3. Most notably, it removes
@ConditionalOnBean(Storage.class)fromGCSBlobStorageConfigurationand swaps GCS client injection pattern from constructor to@Autowiredproperty.It also adds new configuration property
l10n.gcs.projectIdwhich can be explicitly specified rather than using implicit project id from ADC. This is done to match Java auth flow specified in https://docs.cloud.google.com/docs/authentication/client-libraries#java.