Skip to content

feat: support annotation output format in harness - #18

Open
VIDIT45AGARWAL wants to merge 1 commit into
bowtie-json-schema:mainfrom
VIDIT45AGARWAL:support-annotation-output
Open

feat: support annotation output format in harness#18
VIDIT45AGARWAL wants to merge 1 commit into
bowtie-json-schema:mainfrom
VIDIT45AGARWAL:support-annotation-output

Conversation

@VIDIT45AGARWAL

Copy link
Copy Markdown

This updates the python-jschon harness to support the new output argument.

Changes

  • Updated cmd_run to accept the new output parameter
  • When output == "annotations", uses jschon's result.output("basic") to extract annotations and transforms them into Bowtie's expected annotation format
  • When output == "flag", returns the standard {"valid": bool} response as before

@VIDIT45AGARWAL

Copy link
Copy Markdown
Author

Hey @Julian, I have updated python-jschon harness for annotation support.

@Julian

Julian commented Sep 10, 2026

Copy link
Copy Markdown
Member

Nice! Will have a look (looks like I didn't have notifications on)

@VIDIT45AGARWAL

Copy link
Copy Markdown
Author

It seems smoke tests send a basic payload without the new "output" field, which caused a TypeError. Should we pass a default value output="flag" ?

@Julian

Julian commented Sep 10, 2026

Copy link
Copy Markdown
Member

That would sound like an upstream bug in the main repo -- it shouldn't be possible to send invalid requests to harnesses so if that's happening from smoke something very strange is happening.

We likely should smoke test both kinds of input as well.

@VIDIT45AGARWAL

Copy link
Copy Markdown
Author

I think you are right, this is an upstream issue. The smoke test in Bowtie on main does send output:"flag" , but the harness's report.yml workflow installs bowtie's last release (2026.7.4, Jul 30), which predates the output field on the run command. So its run requests lack output entirely, which is what caused TypeError in the harness.

Also you're right that the smoke test will always just send output:"flag" and not output:"annotations", so we should update that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants