WIP - Initial commit, rebuild SDK using TypeScript ... - #7
Conversation
| /** | ||
| * Jekyll class | ||
| */ | ||
| class Jekyll extends Base { |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
| /** | ||
| * CollectionItem class | ||
| */ | ||
| class CollectionItem extends Base { |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
| /** | ||
| * Collection class | ||
| */ | ||
| class Collection extends Base { |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
| * @param {Object} [params] - Additional params (sent to github) | ||
| * @returns {Promise<Object>} - Returns promise with response data | ||
| */ | ||
| _exec (key, action, params = {}) { |
There was a problem hiding this comment.
Function _exec has 53 lines of code (exceeds 25 allowed). Consider refactoring.
| * @param {Array} params.files - Array of file objects with base64 encoded content | ||
| * @param {String} params.message - Message for commit on creating file(s) | ||
| */ | ||
| upsertFiles (params = {}) { |
There was a problem hiding this comment.
Function upsertFiles has 56 lines of code (exceeds 25 allowed). Consider refactoring.
|
Code Climate has analyzed commit daa09fe and detected 14 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 77.5%. View more on Code Climate. |
WIP ...