Skip to content

WIP - Initial commit, rebuild SDK using TypeScript ... - #7

Open
5290charlie wants to merge 1 commit into
masterfrom
wip/feature/upgrade-typescript
Open

WIP - Initial commit, rebuild SDK using TypeScript ...#7
5290charlie wants to merge 1 commit into
masterfrom
wip/feature/upgrade-typescript

Conversation

@5290charlie

Copy link
Copy Markdown
Member

WIP ...

@5290charlie 5290charlie added the WIP Work In Progress label Apr 3, 2020
@5290charlie 5290charlie self-assigned this Apr 3, 2020
Comment thread lib/models/Jekyll.js
/**
* Jekyll class
*/
class Jekyll extends Base {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identical blocks of code found in 2 locations. Consider refactoring.

/**
* CollectionItem class
*/
class CollectionItem extends Base {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identical blocks of code found in 2 locations. Consider refactoring.

Comment thread lib/models/Collection.js
/**
* Collection class
*/
class Collection extends Base {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identical blocks of code found in 2 locations. Consider refactoring.

Comment thread lib/models/GitHub.js
* @param {Object} [params] - Additional params (sent to github)
* @returns {Promise<Object>} - Returns promise with response data
*/
_exec (key, action, params = {}) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function _exec has 53 lines of code (exceeds 25 allowed). Consider refactoring.

Comment thread lib/models/GitHub.js
* @param {Array} params.files - Array of file objects with base64 encoded content
* @param {String} params.message - Message for commit on creating file(s)
*/
upsertFiles (params = {}) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function upsertFiles has 56 lines of code (exceeds 25 allowed). Consider refactoring.

@qlty-cloud-legacy

Copy link
Copy Markdown

Code Climate has analyzed commit daa09fe and detected 14 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 6
Duplication 8

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 77.5%.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WIP Work In Progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant