updates to seed fallback behavior - #1
Merged
NickArrasate merged 2 commits intoJun 5, 2026
Conversation
NickArrasate
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to code quality, configuration, and theming defaults. The most significant changes include updating the JavaScript language version for linting, simplifying Docker volume configuration, and improving how theme images are handled and validated. The changes also ensure that empty or whitespace-only theme image fields are not treated as valid images.
Configuration and Environment Updates:
ecmaVersionin.eslintrc.jsonfrom 9 to 2020, enabling support for newer JavaScript syntax and features.docker-compose.ymlby switching to shorthand syntax for mountingnodemodulesandnpmvolumes, improving readability and maintainability.Theming and Image Handling Improvements:
src/lib/defaultTheme.jsby setting them to empty strings, ensuring that no placeholder images are used by default.imageSetutility inTheme/FileUpload.jsxto check for non-empty, non-whitespace strings, making image validation stricter.App/Footer.jsxto only renderbrandLogo2if it is a non-empty, non-whitespace string, and to trim whitespace before using the value.