Skip to content

updates to seed fallback behavior - #1

Merged
NickArrasate merged 2 commits into
feature/share-updatesfrom
feature/remove-default-fallbacks
Jun 5, 2026
Merged

updates to seed fallback behavior#1
NickArrasate merged 2 commits into
feature/share-updatesfrom
feature/remove-default-fallbacks

Conversation

@chadperson

Copy link
Copy Markdown
Collaborator

This pull request introduces several improvements to code quality, configuration, and theming defaults. The most significant changes include updating the JavaScript language version for linting, simplifying Docker volume configuration, and improving how theme images are handled and validated. The changes also ensure that empty or whitespace-only theme image fields are not treated as valid images.

Configuration and Environment Updates:

  • Updated the ecmaVersion in .eslintrc.json from 9 to 2020, enabling support for newer JavaScript syntax and features.
  • Simplified Docker Compose volume definitions in docker-compose.yml by switching to shorthand syntax for mounting nodemodules and npm volumes, improving readability and maintainability.

Theming and Image Handling Improvements:

  • Cleared default image and logo fields in src/lib/defaultTheme.js by setting them to empty strings, ensuring that no placeholder images are used by default.
  • Improved the imageSet utility in Theme/FileUpload.jsx to check for non-empty, non-whitespace strings, making image validation stricter.
  • Updated the footer in App/Footer.jsx to only render brandLogo2 if it is a non-empty, non-whitespace string, and to trim whitespace before using the value.

@chadperson
chadperson requested a review from NickArrasate June 5, 2026 04:50
@chadperson
chadperson requested a review from 5290charlie as a code owner June 5, 2026 04:50
@NickArrasate
NickArrasate merged commit 03cb411 into feature/share-updates Jun 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants