Merged
Conversation
bizurkur
approved these changes
Mar 4, 2020
allejo
requested changes
Mar 4, 2020
Comment on lines
-14
to
-20
| include: | ||
| - php: 5.5 | ||
| dist: precise | ||
| - php: 5.4 | ||
| dist: precise | ||
| - php: 5.3 | ||
| dist: precise |
Member
There was a problem hiding this comment.
If we're dropping 5.3 - 5.5 support in this PR for the 1.7.x series, then we should bump the composer.json as well.
Line 20 in 9260406
Member
Author
There was a problem hiding this comment.
You are right, just adjusted that. Anybody still running these PHP versions has larger problems than upgrading to the next version of vfsStream, I guess, so it should be safe to drop support for those.
| ------------------ | ||
|
|
||
| * Namespace changed from `org\bovigo\vfs` to `bovigo\vfs` | ||
| - The old namespace still works, but has been deprecated. It will be removed in version 2. |
Member
There was a problem hiding this comment.
Document the bump to 5.6 as a PHP minimum version
allejo
approved these changes
Mar 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports the namespace change introduced with #209 to the 1.x series, as suggested in #221. This allows users to upgrade to 1.7 and adjust the used namespace.
This doesn't contain the name changes for the classes and interfaces yet. I'll introduce those in a separate PR once this gets approved and merged.