Skip to content

Some commits that should together fix the segfaults - #324

Merged
dschwoerer merged 7 commits into
masterfrom
fix-race
Dec 1, 2025
Merged

dschwoerer merged 7 commits into
masterfrom
fix-race

Conversation

@dschwoerer

@dschwoerer dschwoerer commented Nov 27, 2025

Copy link
Copy Markdown
Contributor

Includes #317 and #323

@dschwoerer

Copy link
Copy Markdown
Contributor Author

Woohoo - it seems there are no segfaults anymore.

Time to fix the other bugs!

@dschwoerer

Copy link
Copy Markdown
Contributor Author

Should we merge this, to make it easier fixing the remaining bugs?
#317 and #323 should probably be merged first ...

@dschwoerer
dschwoerer requested a review from ZedThree November 28, 2025 09:43

@ZedThree ZedThree left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to h5netcdf should be fine. CI still has a lot of failures though -- and is it supposed to take an hour?!

@dschwoerer

Copy link
Copy Markdown
Contributor Author

Yes, I think there are some regressions, that are only now noticeable that the segfaults are resolved.
They should be much easier to fix then the segfaults.

I do not know, I checked some python3.8 run from a few days ago, and that was 55min, 3.9 was 45 minutes.

Note that python 3.14 is hugely faster with 20 minutes. From a quick look it seems the errors are the same, so we might really benefit from removing the GIL lock, which would be nice.

@dschwoerer

Copy link
Copy Markdown
Contributor Author

@ZedThree can you reproduce these issues? I tried on my fedora machine, but there everything works fine.
Maybe something is wrong with the h5netcdf wheel?

@dschwoerer dschwoerer mentioned this pull request Dec 1, 2025
@dschwoerer
dschwoerer merged commit d67b533 into master Dec 1, 2025
3 of 13 checks passed
@dschwoerer
dschwoerer deleted the fix-race branch December 1, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants