Conversation
Rather than evolving both potential and vorticity equations, setting `evolve_vorticity` to `false` evolves only potential.
Vorticity is now calculated from phi in `transform` rather than `finally`, so additional permissions are needed.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #570 +/- ##
==========================================
+ Coverage 59.75% 60.52% +0.77%
==========================================
Files 98 98
Lines 10274 10323 +49
Branches 1482 1488 +6
==========================================
+ Hits 6139 6248 +109
+ Misses 3488 3400 -88
- Partials 647 675 +28 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Split the `transform_impl` and `finally` functions into public functions and add unit tests.
Covers the main operating modes, inputs and outputs.
FakeMesh has one X guard cell by default.
Only set the second guard cell if there is more than one guard cell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a switch
evolve_vorticitythat istrueby default, and equations are evolved for bothphiandvort.Setting
evolve_vorticitytofalsemodifies the equations so onlyphiis evolved andvortis calculated fromphi. This reduces the size of the system and reduces the order of the PDE. Exploring whether this helps solve transport with drifts faster.