Skip to content

Relax potential by evolving phi rather than vort - #570

Open
bendudson wants to merge 9 commits into
masterfrom
relax-potential-phi
Open

bendudson wants to merge 9 commits into
masterfrom
relax-potential-phi

Conversation

@bendudson

Copy link
Copy Markdown
Collaborator

Adds a switch evolve_vorticity that is true by default, and equations are evolved for both phi and vort.
Setting evolve_vorticity to false modifies the equations so only phi is evolved and vort is calculated from phi. This reduces the size of the system and reduces the order of the PDE. Exploring whether this helps solve transport with drifts faster.

bendudson added 2 commits May 20, 2026 15:47
Rather than evolving both potential and vorticity equations, setting
`evolve_vorticity` to `false` evolves only potential.
Vorticity is now calculated from phi in `transform` rather than `finally`,
so additional permissions are needed.
@codecov

codecov Bot commented May 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 58.74587% with 125 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.52%. Comparing base (7b61dd8) to head (0730073).

Files with missing lines Patch % Lines
src/relax_potential.cxx 58.74% 87 Missing and 38 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
+ Coverage   59.75%   60.52%   +0.77%     
==========================================
  Files          98       98              
  Lines       10274    10323      +49     
  Branches     1482     1488       +6     
==========================================
+ Hits         6139     6248     +109     
+ Misses       3488     3400      -88     
- Partials      647      675      +28     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

bendudson and others added 5 commits July 2, 2026 17:29
Split the `transform_impl` and `finally` functions into
public functions and add unit tests.
Covers the main operating modes, inputs and outputs.
FakeMesh has one X guard cell by default.
Only set the second guard cell if there is more than one guard cell.
@bendudson bendudson changed the title WIP: Relax potential by evolving phi rather than vort Relax potential by evolving phi rather than vort Jul 4, 2026
@bendudson
bendudson requested a review from malamast July 5, 2026 18:01
@bendudson bendudson added the enhancement New feature or request label Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant