This repository was archived by the owner on Jun 10, 2025. It is now read-only.
Make mayavi an optional dependency - #3
Merged
Merged
Conversation
`mayavi` is not required for all the `boututils` to work, so make it an 'extra' requirement.
Contributor
Author
|
Should allow removing a work-around in |
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
======================================
Coverage 3.82% 3.82%
======================================
Files 38 38
Lines 2926 2926
======================================
Hits 112 112
Misses 2814 2814
Continue to review full report at Codecov.
|
loeiten
approved these changes
Oct 26, 2019
loeiten
left a comment
loeiten
left a comment
Member
There was a problem hiding this comment.
Nice solution. Any suggestions on how often we should bump the version number? Does once every pulled PR make sense?
Contributor
Author
I think that makes sense, it's what we're doing for hypnotoad. I'll bump the version number. |
0.1.2 -> 0.1.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mayaviis not required for all theboututilsto work, so make it an 'extra' requirement.