Skip to content

remove async_trait#103

Merged
futursolo merged 5 commits intobounce-rs:masterfrom
Madoshakalaka:remove-async-trait
Mar 29, 2026
Merged

remove async_trait#103
futursolo merged 5 commits intobounce-rs:masterfrom
Madoshakalaka:remove-async-trait

Conversation

@Madoshakalaka
Copy link
Copy Markdown
Contributor

@Madoshakalaka Madoshakalaka commented Mar 25, 2025

Description

fixes #101

bumped MSRV to 1.75 1.84

Checklist

  • I have self-reviewed and tested this pull request to my best ability.
  • I have added tests for my changes.
  • I have updated docs to reflect any new features / changes in this pull request.
  • I have added my changes to CHANGELOG.md.

Comment thread CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
### Breaking Changes

- Raise MSRV to 1.75.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think removing async-trait is also a breaking change?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good now?

@Madoshakalaka Madoshakalaka requested a review from futursolo March 29, 2026 09:43
Copy link
Copy Markdown
Member

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Madoshakalaka
Copy link
Copy Markdown
Contributor Author

oops. lint problems. fixed now

@Madoshakalaka Madoshakalaka requested a review from futursolo March 29, 2026 10:05
@futursolo futursolo merged commit 252aef8 into bounce-rs:master Mar 29, 2026
4 checks passed
@Madoshakalaka Madoshakalaka deleted the remove-async-trait branch March 29, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No need for async-trait crate anymore?

2 participants