Merged
Conversation
- Add IMPORTANT note that only P0 and P1 issues should be commented on - Define P1 criteria (>10% user impact, visible errors, money/auth/data, broken features) - List what is NOT considered P1 (hypothetical cases, unlikely errors, code style, warnings, theoretical leaks) - Improve review quality by reducing noise from P2/P3 issues Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Comment on lines
69
to
+74
| - [P2] Normal. Should fix eventually (엣지 케이스 미처리) | ||
| - [P3] Low. Nice to have | ||
|
|
||
| ### IMPORTANT: Only comment on P0 and P1 issues. | ||
|
|
||
| Do NOT leave comments for P2 or P3 issues. If an issue is P2 or lower, skip it entirely. |
There was a problem hiding this comment.
[P1] 여기서는 "P0/P1만 코멘트"라고 강하게 제한하지만, 아래 예시 섹션에 [P2] 코멘트 예시가 그대로 남아 있어 지침이 상충합니다(예: Async Context Issue). Copilot이 어떤 규칙을 따라야 하는지 모호해지므로, [P2] 예시를 제거하거나 P1로 재분류하고, P2/P3는 "분류용으로만 유지" 같은 식으로 명확히 적어주세요.
Suggested change
| - [P2] Normal. Should fix eventually (엣지 케이스 미처리) | |
| - [P3] Low. Nice to have | |
| ### IMPORTANT: Only comment on P0 and P1 issues. | |
| Do NOT leave comments for P2 or P3 issues. If an issue is P2 or lower, skip it entirely. | |
| - [P2] Normal. Should fix eventually (엣지 케이스 미처리, 분류용으로만 사용하고 실제 코멘트에는 사용하지 않음) | |
| - [P3] Low. Nice to have (분류용으로만 사용하고 실제 코멘트에는 사용하지 않음) | |
| ### IMPORTANT: Only comment on P0 and P1 issues. | |
| Do NOT leave comments for P2 or P3 issues. If an issue is P2 or lower, skip it entirely. 아래 예시 섹션에 등장하는 P2/P3 코멘트는 우선순위 분류 예시일 뿐이며, 실제 리뷰 코멘트로는 작성하지 않습니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
Copilot 코드 리뷰 지침에 P0/P1 필터링 규칙을 추가하여 리뷰 품질을 개선합니다.
동기
다른 프로젝트의 copilot-instructions와 비교하면서, P0/P1 필터링 규칙을 명시적으로 정의하지 않으면 P2/P3 수준의 이슈까지 코멘트되어 리뷰 노이즈가 증가한다는 것을 발견했습니다.
변경사항
테스트
🤖 Generated with Claude Code