refactor: @Sql 어노테이션을 TestFactory 패턴으로 마이그레이션#557
Merged
Conversation
@SQL 기반 테스트 데이터 설정을 TestFactory 패턴으로 대체하기 위한 헬퍼 클래스 추가: - TestDataSetupHelper: 복합 테스트 데이터 생성 헬퍼 - HistoryTestData: 히스토리 테스트용 데이터 record - MyPageTestData: 마이페이지 테스트용 데이터 record - MyBottleTestData: 마이보틀 테스트용 데이터 record - UserTestFactory: persistUserWithNickname 메서드 추가 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@SQL 어노테이션을 TestFactory 패턴으로 대체: - PicksIntegrationTest: SQL 스크립트 → TestFactory 사용 - RatingIntegrationTest: SQL 스크립트 → TestFactory 사용 - LikesIntegrationTest: SQL 스크립트 → TestFactory 사용 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@SQL 어노테이션을 TestFactory 패턴으로 대체: - UserQueryIntegrationTest: TestDataSetupHelper를 활용한 복합 데이터 설정 - UserCommandIntegrationTest: TestFactory 직접 사용 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@SQL 어노테이션을 TestFactory 패턴으로 대체: - UserHistoryIntegrationTest: TestDataSetupHelper.setupHistoryTestData() 활용 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@SQL 어노테이션을 TestFactory 패턴으로 대체: - ReviewIntegrationTest: ReviewTestFactory 활용 - ReviewReplyIntegrationTest: ReviewTestFactory.persistReviewReply() 활용 - JpaAuditingIntegrationTest: TestFactory 직접 사용 - ReviewObjectFixture: getReviewCreateRequestWithAlcoholId() 메서드 추가 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
모든 통합 테스트가 TestFactory 패턴으로 마이그레이션되어 더 이상 사용되지 않는 SQL 파일 삭제: - init-alcohol.sql - init-help.sql - init-popular_alcohol.sql - init-review-reply.sql - init-review.sql - init-user-history.sql - init-user-mybottle-query.sql - init-user-mypage-query.sql - init-user.sql - schema.sql.bak Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
신규 추가 (bottlenote-mono)
TestDataSetupHelper: 복합 테스트 데이터 생성 헬퍼HistoryTestData,MyPageTestData,MyBottleTestData: 테스트용 데이터 recordUserTestFactory.persistUserWithNickname(): 닉네임 지정 사용자 생성 메서드마이그레이션 (bottlenote-product-api)
삭제
bottlenote-product-api/src/test/resources/init-script/폴더 전체Benefits
Test plan
./gradlew integration_test통과./gradlew check_rule_test통과./gradlew :bottlenote-product-api:test통과🤖 Generated with Claude Code