Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
큐레이션 등록/수정 폼에서 커버 이미지(coverImageUrl)를 필수로 강제하던 프론트 검증/표시를 제거하고, 미등록 시 API 요청에서 해당 필드를 제외하도록 정리한 PR입니다.
Changes:
- Zod 스키마에서
coverImageUrl의min(1)필수 검증 제거 - 커버 이미지 카드 타이틀의 필수 표시(
*) 및 커버 이미지 에러 메시지 UI 제거 - submit 시
coverImageUrl === ''이면undefined로 변환해 요청 body에서 제외
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/pages/curations/useCurationDetailForm.ts | submit 시 빈 문자열 커버 이미지 값을 undefined로 변환하여 요청에서 제외 |
| src/pages/curations/CurationDetail.tsx | 커버 이미지 섹션의 필수 표시/에러 표시 UI 제거 |
| src/pages/curations/curation.schema.ts | coverImageUrl 필수(min) 검증 제거로 선택 입력 허용 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 사항 (Changes)
coverImageUrl필드의min(1)필수 검증 제거*필수 표시 제거coverImageUrl을undefined로 변환하여 API 요청에서 제외변경 이유 (Reason for Changes)
커버 이미지는 필수가 아닌데 폼 검증에서 필수로 강제하고 있었습니다.
API 타입(
CurationCreateRequest,CurationUpdateRequest)에서도coverImageUrl?: string으로 이미 선택 필드인데, 프론트 스키마만min(1)로 막고 있어서 불일치가 있었습니다.테스트 방법 (Test Procedure)
참고 사항 (Additional Information)
"")을undefined로 변환하여 요청 body에서 제외합니다coverImageUrl미전송 시null로 처리될 것으로 예상됩니다🤖 Generated with Claude Code