Merged
Conversation
배너 API에 추가된 mediaType 필드를 프론트엔드 전 계층에 반영하고, 동영상(MP4) 업로드 및 미리보기 기능을 구현한다. - types: MediaType 타입, presigned URL contentType 파라미터 추가 - schema: 폼 스키마에 mediaType 필드 추가 (기본값: IMAGE) - service: S3 presigned URL 요청 시 contentType 전달 - form: 파일 업로드 시 file.type 기반 mediaType 자동 판별 - ImageUpload: 이미지/동영상 accept, 거부 콜백, 미리보기 분기 - BannerImageCard: 허용 외 파일 에러 토스트, mediaType 자동 설정 - BannerPreviewCard: form.mediaType 기반 비디오 미리보기 - fix: blob URL에서 useEffect가 isVideo를 덮어쓰는 버그 수정 - test: 유틸/컴포넌트/서비스/훅/E2E 테스트 51개 추가 (총 129개) Refs: bottle-note/workspace#205 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
uploadToS3에 contentType 파라미터를 추가하여 presigned URL 서명 조건과 S3 PUT 헤더가 항상 동일하도록 보장한다. Addresses review comment by @Copilot on src/services/s3.service.ts:66. PR: #38 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
파일 교체/삭제 시 이전 blob URL을 revokeObjectURL로 정리하여 메모리 누적을 방지한다. 빌드 에러 수정 포함. Addresses review comment by @Copilot on src/components/common/ImageUpload.tsx:95. PR: #38 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
폼 validation 에러 핸들러의 console.log를 제거한다. Addresses review comment by @Copilot on src/pages/banners/BannerDetail.tsx:70. PR: #38 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
[feat] 배너 미디어 타입 지원 (IMAGE/VIDEO) 및 동영상 업로드
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Dashboard v1.2.6
This PR was automatically created by version-check workflow.