-
Notifications
You must be signed in to change notification settings - Fork 0
[feat] 배너 미디어 타입 지원 (IMAGE/VIDEO) 및 동영상 업로드 #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1]
URL.createObjectURL로 만든 blob URL을URL.revokeObjectURL로 정리하지 않아 파일을 여러 번 교체/삭제하면 메모리가 누적될 수 있습니다.배너 등록/수정 페이지에서 미디어를 여러 번 바꾸는 경우 탭 메모리가 계속 증가할 수 있으니, 새 blob URL 생성 전에 이전 URL을 revoke하고 unmount/삭제 시에도 revoke하도록 cleanup을 추가해 주세요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in
e07e49f.변경 내용:
blobUrlRef로 현재 blob URL을 추적하고, 파일 교체 시 이전 blob URL을URL.revokeObjectURL로 정리합니다. 삭제 시에도 동일하게 cleanup합니다.이유: 파일을 여러 번 교체하면 blob URL이 누적되어 메모리 누수가 발생할 수 있습니다.