Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ents Replace mock data with real API integration for banner CRUD operations. Split BannerDetail.tsx (575 lines) into 6 focused card components following the existing WhiskyDetail pattern. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace hardcoded 2099 end date with getOneYearLaterEnd() to avoid MySQL TIMESTAMP overflow (max 2038-01-19). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use FormField wrapper for input validation errors in card components to follow established UI patterns from CLAUDE.md. Also fix Playwright test locator strict mode and form reset timing issues. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add isActive to BannerCreateRequest type and create mutation - Fix sortOrder to use page offset (page * size + index) for pagination - Add error prop to bannerType and textPosition FormField components - Update test data to include isActive in create request Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
[feat] 배너 API 연동 및 컴포넌트 분리
- 스키마: distilleryId, age, cask, description, imageUrl을 선택 필드로 변경 - 기본값: age/cask/description의 초기값을 '-'로 설정하여 미입력 상태 구분 - API 연동: 빈 값을 '-'로 변환하여 백엔드 호환성 유지 - UI: 선택 필드의 required 라벨 제거로 필수 여부 명확화 필수 필드 (6개): 한글명, 영문명, 카테고리, 지역, 도수, 용량 선택 필드 (4개): 증류소, 숙성연도, 캐스크, 설명 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… required - distilleryId: add Korean validation message for min(0) - imageUrl: restore min(1) validation (image is always required) Addresses review comments by @Copilot on whisky.schema.ts:17. PR: #23 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Default form values back to '' (display only) - Convert empty values to '-' only at submit time (storage) - Auto-resolve distilleryId=0 to '-' entry's real ID from API - Remove imagePreviewUrl fallback (imageUrl is now schema-required) Addresses review comments by @Copilot on useWhiskyDetailForm.ts:42,159,177. PR: #23 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
feat: 위스키 폼 필수/선택 필드 분리
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Dashboard v1.0.19
This PR was automatically created by version-check workflow.