Merged
Conversation
The detail API returns alcohols array with full details, not just alcoholIds. Remove N+1 individual alcohol lookups and use the response directly. Bump version to 1.0.18. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove non-existent image/description columns from curation list table - Add table cell padding and adjust column widths for readability - Fix E2E tests to fill all required fields (cover image, whisky) before submit - Add test image fixture and upload/search helpers to page object - Fix ESM __dirname compatibility in curation-detail page object Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add key props to detail page components in route definitions to prevent React from reusing component state when navigating between /new and /:id routes. This fixes the tasting tag form not resetting when navigating from a detail page to the create page via sidebar. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace immediate inputValue() check with toHaveValue('') which
auto-retries until the React useEffect resets the form, fixing the
timing issue between route change and form.reset() execution.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Replace waitForTimeout(2000) with UI-based wait for upload preview - Reorder whisky add before image upload to avoid S3 side-effect on skip - Fix JSDoc to match actual implementation (no separate alcohol fetching) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fix: 큐레이션 상세 API 타입 정렬 및 목록 UI 정리
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Dashboard v1.0.18
This PR was automatically created by version-check workflow.