Repository navigation
test(cleanup): wait for final asynchronous exit records - #583
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows can finish native exit before asynchronous process cleanup has emitted the final
exitedrecord. Two tests used Vitest's default one-second poll, and a protocol-close test allowed only five seconds, the same as one Windows cleanup read budget. Give all three polls 15 seconds and attach the records captured when a poll fails, retaining the original assertion as the cause.The shared crash still requires one exit record per session, native exit code 7, and no duplicate after disposal. The isolated ACP tests still require the explicit terminal-cleanup failure or failed turn and rejection after protocol close. Product timeouts, cleanup behavior, and the 30-second test ceiling are unchanged.
Validation:
CI=1 pnpm run check: 2,858 unit tests and 18 mock behavior cases passed.expect.pollcalls: readiness polls and polls after awaited disposal do not wait for this final-record cleanup gap; existing explicitly bounded cancellation checks remain unchanged.Task #140. The triggering failure is the Windows check job 124605383846 in PR #580. The log records zero exit responses after the default poll; it does not retain the cleanup phase timings.