Skip to content

node-images: enable copr repo #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HarshwardhanPatil07 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −0
Open

node-images: enable copr repo #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions node-images/fedora/Containerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ ARG KUBE_MINOR=1.35
# Pin kernel to 6.19.x to work around a kernel 7.0 regression.
# https://github.com/bootc-dev/bink/issues/52
ARG KERNEL_VERSION=6.19.14-300.fc44
RUN dnf -y install 'dnf5-command(copr)' && \
dnf -y copr enable rhcontainerbot/bootc fedora-44-x86_64

@alicefr alicefr Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do understand why you directly add here. However, I'm reluctant to include this by default. Possibly, what we could is to add a new flavor of the disk image for composefs and this fix for the time it lands in fedora.

We could introduce a new argument that if sets will enable the copr repository and then we add a new GHA that will build the composefs disk image including bootc with this fix. This could helps us to eventually add the reverse dependencies job and test. See bootc-dev/bootc-operator#70

@jlebon jlebon Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interested in your hesitation to just unconditionally add this. Yes, we're special-casing bootc here, but... bootc is special for us so it seems warranted.

Note also that this only affects the buildroot; the COPR repo is not enabled by default in the final node image built.

@alicefr alicefr Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are overwriting the default bootc from fedora. So, does it mean we want always to rely from one of the latest bootc version instead of the default one?

RUN /usr/libexec/bootc-base-imagectl build-rootfs \
--manifest=minimal \
--no-docs \
Expand Down