Support 1.34 and 1.36 kubernetes version #76
Merged
Merged
Conversation
jlebon
reviewed
Jun 26, 2026
Collaborator
Author
|
We need to split the build of the images from the tests. Without the image existing the jobs here are failing. Opened: #78 |
alicefr
force-pushed
the
add-k8s-versions
branch
2 times, most recently
from
1173de6 to
bfc8a1d
Compare
Integration tests were hardcoded to config.DefaultNodeImage (v1.35). To test against other K8s versions, add a NodeImage() helper that reads BINK_NODE_IMAGE and wire it into all cluster creation paths. Assisted-by: Claude Opus 4.6 (1M context) Signed-off-by: Alice Frosi <afrosi@redhat.com>
Extract shared runner setup (kernel config, KSM, Go, system deps, KVM, Podman, bink build, image caching) into a reusable composite action at .github/actions/setup-bink. Assisted-by: Claude Opus 4.6 (1M context) Signed-off-by: Alice Frosi <afrosi@redhat.com>
Replace duplicated setup steps with the composite action. Add integration-tests-k8s-versions job for testing non-default K8s versions. Assisted-by: Claude Opus 4.6 (1M context) Signed-off-by: Alice Frosi <afrosi@redhat.com>
Replace inline CI setup steps with the shared setup-bink composite action to avoid duplication across workflow files. Assisted-by: Claude Opus 4.6 (1M context) Signed-off-by: Alice Frosi <afrosi@redhat.com>
alicefr
force-pushed
the
add-k8s-versions
branch
from
bfc8a1d to
ec815a8
Compare
jlebon
approved these changes
Jun 30, 2026
| - name: Get supported Kubernetes versions | ||
| id: set-matrix | ||
| run: | | ||
| DEFAULT="1.35" |
Collaborator
There was a problem hiding this comment.
For a follow-up: ideally this too would be derived from a file in the repo which serves as the source of truth for what the default is. For the go code we can from the Makefile set a global var via GLDFLAGS="-X ....
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build and run some smoke test on node image based on kubernetes 1.34 and 1.36. This is required by the bootc-operator by bootc-dev/bootc-operator#48
This also introduce a common action for setting up bink and to be reused among the various flavor of the integration tests, the last commit ec815a8 includes the factoring for composefs