Skip to content

Conversation

@joaquintides
Copy link
Member

  • Removed install step as it duplicated generated HTML files and Antora already puts its output in the final destination anyway.
  • Deletes subdirectory node_modules after Antora generation: this directory has slipped previously in release archives (seemingly, only bin directories are automatically located and removed).

Fixes #330.

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://336.unordered.prtest2.cppalliance.org/libs/unordered/doc/html/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-01-02 11:00:51 UTC

@sdarwin
Copy link
Contributor

sdarwin commented Jan 2, 2026

why not put the docs in doc/html/ instead of doc/html/unordered/ ?

@joaquintides
Copy link
Member Author

why not put the docs in doc/html/ instead of doc/html/unordered/ ?

Backwards compatibility.

@sdarwin
Copy link
Contributor

sdarwin commented Jan 2, 2026

Backwards compatibility

OK.

I think, in the future, if the "redirect to latest version" implements more logic to check the presence or absence of the redirect file, it could also include logic to fix unordered as an exception. However a prerequisite is getting a basic feature working, which is not there yet.

@joaquintides joaquintides merged commit af47772 into develop Jan 3, 2026
129 of 132 checks passed
@joaquintides joaquintides deleted the fix/doc-jamfile branch January 3, 2026 15:50
return [ property-set.empty ] $(files) ;
actions cleanup-node-modules
{
bash -c "rm -rf node_modules"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bash -c shouldn't be necessary here. It is needed in run-script because otherwise building from the doc directory would invoke build_antora.sh (and not the relative path to that script), which will fail.

rm is a shell command, so it doesn't need another shell wrapper. On the other hand, node_modules is incorrect, as it only works if b2 is invoked from the doc directory. Replace with this:

import path ;
path-constant DOC_DIR : . ;
.node_modules = [ path.join $(DOC_DIR) node_modules ] ;

actions cleanup-node-modules
{
    rm -rf $(.node_modules)
}

@joaquintides joaquintides restored the fix/doc-jamfile branch January 4, 2026 15:43
@joaquintides joaquintides deleted the fix/doc-jamfile branch January 4, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

duplicate documentation

5 participants