Fix subscript-expression to comply with C++23 comma separator rules#124
Open
NEIL-smtg wants to merge 1 commit intoboostorg:developfrom
Open
Fix subscript-expression to comply with C++23 comma separator rules#124NEIL-smtg wants to merge 1 commit intoboostorg:developfrom
NEIL-smtg wants to merge 1 commit intoboostorg:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating this PR in response to #123
In C++23, the grammar for subscript-expressions was updated to accept an expression-list, which causes the top-level comma (,) to be treated as a separator rather than part of a single expression. This leads to parsing issues when using comma expressions directly inside subscript operators.
To address this, affected expressions have been wrapped in parentheses to ensure the intended evaluation order is preserved and to maintain compatibility with C++23 and beyond.
Example fix: