Skip to content

FizzBuzzプログラムを追加 - #1

Open
bonsaiworks8 wants to merge 2 commits into
mainfrom
fizzbuzz
Open

FizzBuzzプログラムを追加#1
bonsaiworks8 wants to merge 2 commits into
mainfrom
fizzbuzz

Conversation

@bonsaiworks8

Copy link
Copy Markdown
Owner

レビューよろしくお願いします。

@JunichiIto JunichiIto left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1点コメントしました〜。

Comment thread 01.fizzbuzz/fizz_buzz.rb Outdated
@@ -0,0 +1,15 @@
#!/usr/bin/env ruby

numbers=[*1..20] # splat展開

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=の前後にはスペースを入れましょう。
あと、コメントも不要です〜。
参考 【動画付き・初心者向け】コメントにはWHYを書こう 〜不要なコメントと必要なコメントの違いについて〜 - Qiita

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正しました。お手数ですが再度ご確認よろしくお願いします。

@JunichiIto JunichiIto left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認しました。OKです!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants