This repository was archived by the owner on Nov 13, 2023. It is now read-only.
Add ModalDownsampler#23
Open
superdump wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
I've tried it for my blocky voxel terrain stuff and it's really slow. Perhaps it's useful for someone? |
Owner
|
Maybe you could add a benchmark in I also suspect that using the |
bonsairobo
force-pushed
the
main
branch
2 times, most recently
from
1bd1c6c to
af0582a
Compare
bonsairobo
force-pushed
the
main
branch
2 times, most recently
from
5dfcb24 to
790ac87
Compare
bonsairobo
force-pushed
the
main
branch
4 times, most recently
from
3199918 to
4e9e0c1
Compare
bonsairobo
force-pushed
the
main
branch
7 times, most recently
from
8645945 to
a69d051
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something like this I think. In the test I was trying to use 1x1x1 lod0 chunks and a 2x2x2 superchunk and lod0 extent, thinking that it would downsample the 2x2x2 extent of lod0 to a 1x1x1 lod1, but I hit the assertion on the dst shape being
Point3i::ZERO. I don't understand why.