Repository navigation
fix(wake): wake-auto-t3 logs the signal that stops it - #189
Conversation
On SIGTERM or SIGINT the supervisor aborted and returned 0 without a log line, so a signal sent by anything other than the service manager looked like a normal stop in the journal. It now logs the signal name once before shutdown. Closes #187.
|
@coderabbitai full review |
There was a problem hiding this comment.
bompus has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 23 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Merge record for the current head:
|
swarmail wake-auto-t3now logsswarmail wake-auto-t3: received SIGTERM; stopping(orSIGINT) once, before it shuts down. Before, both signals aborted the supervisor andmainreturned 0 with no output, so a stop from anything other thansystemctl stoplooked the same as a normal one in the journal.Closes #187. The unit's restart policy and the bridge restart behavior are not touched; the exit status stays 0.
bun run checkexits 0.bun test: 1294 pass, 7 skip, 1 fail. The failure iswake cursor preserves unread batches through bounded loss, acknowledgement and restart orderings, which times out at 30 s under host load (about 8 here). It fails the same way on unmodifiedmainand does not involve this change.Summary by cubic
Logs the signal that stops
swarmail wake-auto-t3, so SIGTERM or SIGINT no longer looks like a silent exit 0 in the journal. The supervisor now writesswarmail wake-auto-t3: received SIGTERM; stopping(orSIGINT) once before aborting, and a changelog line is added under Unreleased. Closes #187.Written for commit e8feb4d. Summary will update on new commits.