Skip to content

fix(wake): wake-auto-t3 logs the signal that stops it - #189

Merged
bompus merged 1 commit into
mainfrom
fix/wake-auto-t3-signal-log
Oct 23, 2026
Merged

bompus merged 1 commit into
mainfrom
fix/wake-auto-t3-signal-log

Conversation

@bompus

@bompus bompus commented Oct 23, 2026 •

Copy link
Copy Markdown
Owner

swarmail wake-auto-t3 now logs swarmail wake-auto-t3: received SIGTERM; stopping (or SIGINT) once, before it shuts down. Before, both signals aborted the supervisor and main returned 0 with no output, so a stop from anything other than systemctl stop looked the same as a normal one in the journal.

Closes #187. The unit's restart policy and the bridge restart behavior are not touched; the exit status stays 0.

  • The existing supervisor test that sends SIGTERM now also asserts the log line appears exactly once. With the source change stashed that assertion fails; with it, it passes.
  • bun run check exits 0.
  • Full bun test: 1294 pass, 7 skip, 1 fail. The failure is wake cursor preserves unread batches through bounded loss, acknowledgement and restart orderings, which times out at 30 s under host load (about 8 here). It fails the same way on unmodified main and does not involve this change.
  • A changelog line is added under Unreleased.

Summary by cubic

Logs the signal that stops swarmail wake-auto-t3, so SIGTERM or SIGINT no longer looks like a silent exit 0 in the journal. The supervisor now writes swarmail wake-auto-t3: received SIGTERM; stopping (or SIGINT) once before aborting, and a changelog line is added under Unreleased. Closes #187.

  • The supervisor test that sends SIGTERM now asserts the log appears exactly once; it fails with the change stashed.

Written for commit e8feb4d. Summary will update on new commits.

View guided diff Turn on auto-fix

On SIGTERM or SIGINT the supervisor aborted and returned 0 without a log line, so a signal sent by anything other than the service manager looked like a normal stop in the journal. It now logs the signal name once before shutdown. Closes #187.
@bompus

bompus commented Oct 23, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai full review

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bompus has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 23 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between d0999d9 and e8feb4d.

📒 Files selected for processing: 3
  • CHANGELOG.md
  • src/wake-auto-t3.ts
  • test/wake-auto-t3.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 23 minutes.

@bompus

bompus commented Oct 23, 2026

Copy link
Copy Markdown
Owner Author

Merge record for the current head:

  • CI: check and windows passed.
  • CodeRabbit: asked once; it reported "Review rate limited", so no review. Skipped for no capacity.
  • Greptile: skipped. Its review reported the 50-credit trial limit; no plan upgrade was bought.
  • cubic: skipped (its check reports "skipping").
  • Local: an independent review of the diff found no defects (one changelog wording fix, applied); bun run check exit 0; the new assertion fails without the source change. Full bun test has one failure, a 30 s timeout in the wake-orderings test, which fails the same way on unmodified main under load.

@bompus
bompus merged commit e52c581 into main Oct 23, 2026
4 checks passed
@bompus
bompus deleted the fix/wake-auto-t3-signal-log branch October 23, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wake-auto-t3 exits 0 with no log line when it receives SIGTERM or SIGINT

1 participant